Document that EntityManager::flush() can throw DBAL's UniqueConstraintViolationException
#313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VasekPurchart
changed the title
EntityManager::flush() can throw Doctrine\DBAL\Exception\UniqueConstraintViolationExceptionEntityManager::flush() can throw DBAL's UniqueConstraintViolationException
VasekPurchart
force-pushed
the
flush-exception
branch
2 times, most recently
from
67eae8e to
8c3299a
Compare
…n\UniqueConstraintViolationException
VasekPurchart
force-pushed
the
flush-exception
branch
from
8c3299a to
6cb02b9
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295 and as mentioned there - there is no intention in adding it in Doctrine ORM and I also think it should not be there. So either PHPStan has to understand that the exception can go from DBAL to
flush()or we have to help him and that is why I think it should be in this repo.